Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved operations G-L to ov namespace #7344

Merged
merged 45 commits into from
Sep 6, 2021

Conversation

ilyachur
Copy link
Contributor

@ilyachur ilyachur commented Sep 2, 2021

Details:

@ilyachur ilyachur force-pushed the move_all_g_l_ops_to_ov branch from 1af25ef to fd1552a Compare September 3, 2021 03:29
@ilyachur ilyachur added the category: Core OpenVINO Core (aka ngraph) label Sep 3, 2021
@ilyachur ilyachur added this to the 2022.1 milestone Sep 3, 2021
@ilyachur ilyachur marked this pull request as ready for review September 3, 2021 03:30
@ilyachur ilyachur requested a review from a team September 3, 2021 03:30
@ilyachur ilyachur force-pushed the move_all_g_l_ops_to_ov branch from fd1552a to 2c97cbd Compare September 3, 2021 07:55
ngraph/core/src/op/hsigmoid.cpp Outdated Show resolved Hide resolved
ngraph/core/src/op/log.cpp Outdated Show resolved Hide resolved
ngraph/core/src/op/loop.cpp Outdated Show resolved Hide resolved
ngraph/core/src/op/hswish.cpp Outdated Show resolved Hide resolved
ngraph/core/src/op/gru_cell.cpp Outdated Show resolved Hide resolved
@ilyachur ilyachur force-pushed the move_all_g_l_ops_to_ov branch from 2c97cbd to 78786d7 Compare September 6, 2021 03:49
@ilyachur ilyachur force-pushed the move_all_g_l_ops_to_ov branch from 78786d7 to c81e5e6 Compare September 6, 2021 04:23
///
class NGRAPH_API LSTMSequence : public util::RNNCellBase {
public:
NGRAPH_RTTI_DECLARATION;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NGRAPH_RTTI_DECLARATION;
OPENVINO_RTTI_DECLARATION;

///
class NGRAPH_API LSTMSequence : public Op {
public:
NGRAPH_RTTI_DECLARATION;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NGRAPH_RTTI_DECLARATION;
OPENVINO_RTTI_DECLARATION;

/// \brief Iterate a body over tensors, accumulating into tensors.
class NGRAPH_API TensorIterator : public op::util::SubGraphOp {
public:
NGRAPH_RTTI_DECLARATION;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
NGRAPH_RTTI_DECLARATION;
OPENVINO_RTTI_DEFINITION;

namespace op {
namespace v0 {
/// \brief Iterate a body over tensors, accumulating into tensors.
class NGRAPH_API TensorIterator : public op::util::SubGraphOp {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class NGRAPH_API TensorIterator : public op::util::SubGraphOp {
class OPENVINO_API TensorIterator : public op::util::SubGraphOp {

/// \sa LSTMCell, RNNCell, GRUCell
///
///
class NGRAPH_API LSTMSequence : public util::RNNCellBase {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
class NGRAPH_API LSTMSequence : public util::RNNCellBase {
class OPENVINO_API LSTMSequence : public util::RNNCellBase {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix in the next PR

@ilyachur ilyachur merged commit e3aed98 into openvinotoolkit:master Sep 6, 2021
@ilyachur ilyachur deleted the move_all_g_l_ops_to_ov branch September 6, 2021 08:07
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 6, 2021
* Moved ngraph::Node to ov namespace

* Fixed code style

* Fixed VPU

* Fixed GNA

* Fixed tests

* Added aliases for backward compatibility

* Fix clDNN

* Try to fix build

* Fixed comment

* Renamed RTTI macros

* Moved op utils to ov namespace

* Fixed ngraph library build

* Fixed unit-tests

* Changed src folder

* Fixed recurrent_sequence

* Changed low latency

* Fixed serialize

* Fixed ieFuncTests

* Try to fix windows

* Remove custom operator<< from tests

* Fixed build

* Moved operations from A to ov namespace

* Moved operations from B and C to ov namespace

* Moved operations D-F to ov namespace

* Update ngraph/core/src/op/embeddingbag_offsets_sum.cpp

Co-authored-by: Katarzyna Mitrus <[email protected]>

* Update ngraph/core/src/op/embeddingbag_packedsum.cpp

Co-authored-by: Katarzyna Mitrus <[email protected]>

* Fixed RTTI

* Moved operations G-L to ov namespace

* Fixed RTTI

Co-authored-by: Ilya Lavrenov <[email protected]>
Co-authored-by: Katarzyna Mitrus <[email protected]>
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
* Moved ngraph::Node to ov namespace

* Fixed code style

* Fixed VPU

* Fixed GNA

* Fixed tests

* Added aliases for backward compatibility

* Fix clDNN

* Try to fix build

* Fixed comment

* Renamed RTTI macros

* Moved op utils to ov namespace

* Fixed ngraph library build

* Fixed unit-tests

* Changed src folder

* Fixed recurrent_sequence

* Changed low latency

* Fixed serialize

* Fixed ieFuncTests

* Try to fix windows

* Remove custom operator<< from tests

* Fixed build

* Moved operations from A to ov namespace

* Moved operations from B and C to ov namespace

* Moved operations D-F to ov namespace

* Update ngraph/core/src/op/embeddingbag_offsets_sum.cpp

Co-authored-by: Katarzyna Mitrus <[email protected]>

* Update ngraph/core/src/op/embeddingbag_packedsum.cpp

Co-authored-by: Katarzyna Mitrus <[email protected]>

* Fixed RTTI

* Moved operations G-L to ov namespace

* Fixed RTTI

Co-authored-by: Ilya Lavrenov <[email protected]>
Co-authored-by: Katarzyna Mitrus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants